Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permanent tag icons #4804

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: permanent tag icons #4804

merged 2 commits into from
Nov 6, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 5, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Removes lock icon from non-permanent tags

How did you test this code?

Please describe.

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 5, 2024 15:33
@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:08pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 7:08pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4804 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4804 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4804 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4804 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4804 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4804 Finished ✅ Results ✅

@kyle-ssg kyle-ssg linked an issue Nov 5, 2024 that may be closed by this pull request
Only permanent tags should show the lock icon #4794
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Uffizzi Preview deployment-57963 was deleted.

matthewelwell
matthewelwell approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment

frontend/web/components/tags/TagContent.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added fix and removed fix labels Nov 5, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 57ad28c Nov 6, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the fix/permanent-tag-icons branch November 6, 2024 09:47
@flagsmithdev flagsmithdev mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only permanent tags should show the lock icon
2 participants
@kyle-ssg @matthewelwell