-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Edit identity override with prevent flag defaults enabled #4809
fix: Edit identity override with prevent flag defaults enabled #4809
Conversation
@dougfabris is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
hideValue
param from Value
Uffizzi Preview |
Hey @dougfabris, thanks for the PR! Prevent_flag_defaults aims to stop from defining a default remote configuration when creating a flag (which sets a default for all environments), forcing people to set it later per environment. Although your PR does fix an issue where it prevents user overrides, it also stops prevent_flag_defaults from working - we can define on a remote config value on flag creation with this change. Instead this should do something along the lines of |
So in fact I was missing something then. I didn't knew about the remote config you mentioned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dougfabris !
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
It adds the identity verification in
hideValue
param on theValue
component in order to render the input fields, where wasn't possible to edit under identity overrideCloses: #4771
How did you test this code?
Note to the reviewer: I was looking into it and indeed removing the parameter mentioned to the
Value
component seems to solve the issue. But I'm afraid I'm missing something because the verification usingprevent_flag_defaults
was added 2 years ago here #1453