Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow any auth except LDAP and SAML to change email #4810

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: Allow any auth except LDAP and SAML to change email #4810

merged 1 commit into from
Nov 7, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Allows oauth users to change email, see #4660

How did you test this code?

Verified email/oauth users can see the change email UI

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 6, 2024 10:12
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:13am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 6, 2024 10:13am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4810 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4810 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4810 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4810 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4810 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4810 Finished ✅ Results ✅

@kyle-ssg kyle-ssg linked an issue Nov 6, 2024 that may be closed by this pull request
UI: Allow org admin to hide change email and change password #4660
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Uffizzi Preview deployment-58011 was deleted.

@matthewelwell matthewelwell merged commit 10eb571 into main Nov 7, 2024
30 checks passed
@matthewelwell matthewelwell deleted the fix/allow-oauth-to-change-email branch November 7, 2024 12:09
@flagsmithdev flagsmithdev mentioned this pull request Nov 7, 2024
Merged
@matthewelwell matthewelwell mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Allow org admin to hide change email and change password
2 participants
@kyle-ssg @matthewelwell