fix: make clone_feature_states_async write only #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4811 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 1180 1180
Lines 41213 41214 +1
=======================================
+ Hits 40113 40114 +1
Misses 1100 1100 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
Nov 7, 2024
matthewelwell
deleted the
chore/make-clone_feature_states_async-write-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Makes the field
clone_feature_states_asyncwrite only. This field was designed to be write only but the configuration was missing and hence it's returningFalseon all requests (because it doesn't exist on the response entity).The alternative here would be to patch the attribute directly onto the environment in the response, but for the sake of a very small breaking API change which no-one will be using directly, I think we should just remove it from the response.
How did you test this code?
Updated an existing integration test.