fix: users with VIEW_ENVIRONMENT should be able to retrieve environment

[matthewelwell]

Changes

Fixes an issue where users with VIEW_ENVIRONMENT permission weren't able to call the GET /environments/:key endpoint.

Also fixes the same issue for the trait-keys endpoint, although it's not used by the Flagsmith UI.

How did you test this code?

Added new test cases.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)			Nov 6, 2024 5:14pm
flagsmith-frontend-preview	⬜️ Ignored (Inspect)			Nov 6, 2024 5:14pm
flagsmith-frontend-staging	⬜️ Ignored (Inspect)			Nov 6, 2024 5:14pm

[github-actions]

Docker builds report

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4814	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4814	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4814	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith:pr-4814	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4814	Finished ✅	Results ✅

[github-actions]

Uffizzi Preview deployment-58034 was deleted.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (364c565) to head (4e0df91).
Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4814   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files        1180     1180           
  Lines       41213    41223   +10     
=======================================
+ Hits        40113    40123   +10     
  Misses       1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.