Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tag based permissions validation #4815

Merged
merged 105 commits into from
Nov 12, 2024
Merged

feat: tag based permissions validation #4815

merged 105 commits into from
Nov 12, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 6, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adjusts frontend to query permissions based on tags, requires #4813

useHasPermission and <Permission will now accept an optional tags array which will be used as an additional check against tag_based_permissions before returning a result.

How did you test this code?

waiting on #4813

flagsmithdev and others added 30 commits October 8, 2024 14:03
@flagsmithdev
chore(main): release 2.145.0 (#4699)
ea4687e
@khvn26
ci: Trivy enhancements (#4703)
cd13caa
@kyle-ssg
chore: tidy up info message (#4702)
c1de4d0
@dependabot
chore(deps): bump cookie and express in /docs (#4707)
c6fce2f 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @zachaysan
chore(deps): bump django from 4.2.15 to 4.2.16 in /api (#4706)
d0a6caf 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zach Aysan <zachaysan@gmail.com>
@kyle-ssg @pre-commit-ci
docs: Update local storage key in docs (#4715)
54796de 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@zachaysan
feat: Set base url for segment (#4684)
4e833b8
@khvn26
fix(ci): Anonymous registry pushes attempted for Tribvy databases (#4716
205988d 
)
@dependabot @zachaysan
chore(deps): bump cookie and express in /frontend (#4721)
ad6b842 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zach Aysan <zachaysan@gmail.com>
@matthewelwell
docs: remove CDN option from docs (#4722)
1456ae8
@khvn26
chore(ci): Fix typo in Trivy cron job (#4723)
6005257
@kyle-ssg
chore: Encourage org emails (#4714)
30456c1
@kyle-ssg
chore: Add email to audit log (#4713)
febf35f
@kyle-ssg
feat: Hide change email when auth_type !== 'EMAIL' (#4712)
27109fd
@kyle-ssg
chore: remove identity from detail page (#4711)
d39d9dd
@zachaysan
fix: Remove mailer lite (#4705)
1c71905
@matthewelwell
chore: update dashboard_alias index name (#4724)
88acdfa
@flagsmithdev
chore(main): release 2.146.0 (#4719)
0130eb4
@kyle-ssg
fix: subscription state (#4710)
796fb01
@kyle-ssg
feat: organisation integrations (#4704)
d76a6f0
@khvn26
fix: Invalid Segment base URLs (#4727)
8b823a7
@flagsmithdev
chore(main): release 2.147.0 (#4728)
02302c5
@matthewelwell
fix: add trailing slash to endpoint to retrieve features after featur…
cbd08f3 
…e create (#4730)
@kyle-ssg
fix: Duplicated segment conditions on save (#4726)
8825971
@kyle-ssg
feat: Persist identity search type (#4729)
08cdf67
@flagsmithdev
chore(main): release 2.148.0 (#4731)
324fe12
@kyle-ssg
fix: Combine segment override and value change requests (#4734)
714a68b
@khvn26
fix: AttributeError when using LOGGING_CONFIGURATION_FILE environ…
2aad0a1 
…ment variable (#4693)
@khvn26
fix(ci): Failing Trivy cron job (#4741)
dbb9ddf
@khvn26
fix(ci): Trivy scan triggered when no scan requested (#4742)
1ffef49
@github-actions github-actions bot added docs Documentation updates infrastructure feature New feature or request and removed feature New feature or request infrastructure docs Documentation updates labels Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Uffizzi Preview deployment-58185 was deleted.

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (85556a0) to head (a940e9a).
Report is 49 commits behind head on feat/tag-based-permissions.

Additional details and impacted files 
@@                      Coverage Diff                       @@
##           feat/tag-based-permissions    #4815      +/-   ##
==============================================================
+ Coverage                       97.30%   97.33%   +0.02%     
==============================================================
  Files                            1175     1180       +5     
  Lines                           40904    41231     +327     
==============================================================
+ Hits                            39802    40131     +329     
+ Misses                           1102     1100       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added docs Documentation updates infrastructure feature New feature or request and removed feature New feature or request infrastructure docs Documentation updates labels Nov 12, 2024
@github-actions github-actions bot added docs Documentation updates infrastructure feature New feature or request and removed feature New feature or request infrastructure docs Documentation updates labels Nov 12, 2024
@kyle-ssg kyle-ssg merged commit a940e9a into feat/tag-based-permissions Nov 12, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the feat/tag-based-permissions-validation branch November 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato Awaiting requested review from rolodato rolodato is a code owner automatically assigned from Flagsmith/flagsmith-docs

@zachaysan zachaysan Awaiting requested review from zachaysan zachaysan is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees
No one assigned
Labels
api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.