fix: replace alter field with adding a new field #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
4 tasks
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4817 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 1180 1182 +2
Lines 41223 41267 +44
=======================================
+ Hits 40123 40167 +44
Misses 1100 1100 ☔ View full report in Codecov by Sentry. |
matthewelwell
requested review from
zachaysan
and removed request for
a team
Docker builds report
|
khvn26
reviewed
Nov 12, 2024
khvn26
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Alternate implementation of #4816
How did you test this code?
To test the updates to migration 0039, I ran the migration locally. Verified that
python manage.py makemigrations usersdoesn't think there are any new migrations to make.To test the new migration 0040, I ran it in an environment which had run both implementations of 0039 and observed that the behaviour was correct.
In both cases, I ran the API locally post migration and verified that the application runs as expected.
Note that I was able to also add a migration test for 0039 but this would be quite challenging to achieve for 0040.