Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log commands in Docker entrypoint #4826

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Nov 11, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add logging to the Docker entrypoint script, and fix shellcheck issues.

https://github.com/koalaman/shellcheck/wiki/SC2039
https://github.com/koalaman/shellcheck/wiki/SC2112
https://github.com/koalaman/shellcheck/wiki/SC2039

How did you test this code?

% docker run -it ghcr.io/flagsmith/flagsmith:pr-4826 --help
+ '[' --help '=' migrate ]
+ '[' --help '=' serve ]
+ '[' --help '=' run-task-processor ]
+ '[' --help '=' migrate-and-serve ]
+ default --help
+ python manage.py --help

Type 'manage.py help <subcommand>' for help on a specific subcommand.

Available subcommands:
[...]

@rolodato rolodato requested a review from a team as a code owner November 11, 2024 22:02
@rolodato rolodato requested review from gagantrivedi and removed request for a team November 11, 2024 22:02
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 11, 2024 10:02pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Nov 11, 2024 10:02pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Nov 11, 2024 10:02pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Nov 11, 2024
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4826 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4826 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4826 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4826 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4826 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4826 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Uffizzi Preview deployment-58168 was deleted.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (e6f1bac) to head (1858304).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4826   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files        1180     1180           
  Lines       41223    41224    +1     
=======================================
+ Hits        40123    40124    +1     
  Misses       1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit b2d7500 into main Nov 12, 2024
34 checks passed
@matthewelwell matthewelwell deleted the feat/log-docker-commands branch November 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants