-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Google OAuth broken in unified docker image #4839
Conversation
@jiulongw is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d1c5bbd
to
594f15a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jiulongw!
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4839 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 1182 1182
Lines 41272 41273 +1
=======================================
+ Hits 40179 40180 +1
Misses 1093 1093 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
594f15a
to
16ff185
Compare
@matthewelwell thanks for reviewing! Just fixed the formatting. |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Allows changing
SECURE_CROSS_ORIGIN_OPENER_POLICY
Django settings via environment variable.This setting is set to "same-origin" by default by Django, which effectively blocks Google's OAuth popup window sending access token to Flagsmith.
How did you test this code?
DJANGO_SECURE_CROSS_ORIGIN_OPENER_POLICY
tosame-origin-allow-popups
in the environment variable.