fix(project/serializer): limit edit to only fields that make sense #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
requested review from
matthewelwell
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
matthewelwell
approved these changes
Nov 19, 2024
api/projects/serializers.py
Outdated
Comment on lines
52
to
55
| def update(self, instance: Project, validated_data: dict) -> Project: | ||
| # Prevent updates to `organisation` field | ||
| validated_data.pop("organisation", None) | ||
| return super().update(instance, validated_data) |
There was a problem hiding this comment.
I think it's perhaps better to just add a new serializer for update requests which adds organisation to the read only fields?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4846 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 1182 1183 +1
Lines 41287 41306 +19
=======================================
+ Hits 40194 40213 +19
Misses 1093 1093 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
matthewelwell
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Stop User from updating
organisation,enable_dynamo_dbandedge_v2_migration_statusHow did you test this code?
Covered by unit tests