Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert https://github.com/Flagsmith/flagsmith/pull/4817 #4850

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Nov 20, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Revert #4817 because alter table will need a lock anyway

How did you test this code?

n/a

@gagantrivedi gagantrivedi requested a review from a team as a code owner November 20, 2024 11:02
@gagantrivedi gagantrivedi requested review from khvn26 and removed request for a team November 20, 2024 11:02
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 11:16am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 11:16am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 11:16am

@github-actions github-actions bot added the api Issue related to the REST API label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4850 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4850 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4850 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4850 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4850 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4850 Finished ✅ Results

@gagantrivedi gagantrivedi changed the title revert: https://github.com/Flagsmith/flagsmith/pull/4817 fix: revert https://github.com/Flagsmith/flagsmith/pull/4817 Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Uffizzi Preview deployment-58403 was deleted.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (a33633f) to head (c6ea80f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4850      +/-   ##
==========================================
- Coverage   97.35%   97.35%   -0.01%     
==========================================
  Files        1183     1181       -2     
  Lines       41292    41270      -22     
==========================================
- Hits        40199    40177      -22     
  Misses       1093     1093              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gagantrivedi gagantrivedi merged commit 793a110 into main Nov 21, 2024
34 checks passed
@gagantrivedi gagantrivedi deleted the fix/long-transaction branch November 21, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants