Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set Hubspot cookie name from request body #4880

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

This allows setting Hubspot from the request body of the related API calls in order to work around a cookie limitation of CORS.

How did you test this code?

Altered a number of tests.

@zachaysan zachaysan requested a review from a team as a code owner December 2, 2024 20:19
@zachaysan zachaysan requested review from gagantrivedi and removed request for a team December 2, 2024 20:19
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 2, 2024 8:19pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Dec 2, 2024 8:19pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Dec 2, 2024 8:19pm

@github-actions github-actions bot added the api Issue related to the REST API label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4880 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4880 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4880 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4880 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4880 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4880 Finished ✅ Results

@github-actions github-actions bot added the fix label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Uffizzi Preview deployment-58729 was deleted.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (6c4090d) to head (eb0a1c4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4880   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files        1187     1187           
  Lines       41301    41303    +2     
=======================================
+ Hits        40219    40221    +2     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 7d3b253 into main Dec 3, 2024
34 checks passed
@matthewelwell matthewelwell deleted the fix/set_hubspot_cookie_name_from_request_body branch December 3, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants