Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set project change requests url #4920

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: Set project change requests url #4920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8fd9f4
Update url for test
zachaysan Dec 13, 2024
1ee6082
Make project singular
zachaysan Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/features/workflows/core/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def url(self):
url += f"/project/{self.environment.project_id}"
url += f"/environment/{self.environment.api_key}"
else:
url += f"/projects/{self.project_id}"
url += f"/project/{self.project_id}"
url += f"/change-requests/{self.id}"
return url

Expand Down
4 changes: 1 addition & 3 deletions api/tests/unit/features/workflows/core/test_unit_workflows_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,5 @@ def test_url_via_project(project_change_request: ChangeRequest) -> None:
# Then
project_id = project_change_request.project_id
expected_url = get_current_site_url()
expected_url += (
f"/projects/{project_id}/change-requests/{project_change_request.id}"
)
expected_url += f"/project/{project_id}/change-requests/{project_change_request.id}"
assert url == expected_url
Loading