Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds plus indicator when is_num_identity_overrides_complete is false #4938

Open
wants to merge 1 commit into
base: fix/speed_up_identity_overrides
Choose a base branch
from

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Dec 23, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds plus indicator when is_num_identity_overrides_complete is false implemented in #4840

ref: #4931

How did you test this code?

Mannualy
Screenshot 2024-12-23 at 12 20 18

ref: #4931

Signed-off-by: Tiago Fonseca <tiago@tiagopaiva.me>
@tiagoapolo tiagoapolo requested a review from a team as a code owner December 23, 2024 17:53
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team December 23, 2024 17:53
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 5:55pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 5:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 23, 2024 5:55pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Dec 23, 2024
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4938 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4938 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4938 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4938 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4938 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4938 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Uffizzi Ephemeral Environment deployment-59309

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4938

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we'll probably want to test it once #4840 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants