-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spatial_hist is a class instance #271
Comments
Actually, I've thought about this a bit more, and I think it might be okay... Because we direct the block attributes to the source attributes (see here), provided each class correctly sets its own @josh0-jrg, I'd suggest testing this: create a detector-specific (i.e. LZ) |
I think you will have to make sure that the |
@Ashley-Joy, did you bump into the same issue as well? You mentioned having some troubles fitting NR with multiple sources to take care of the multiple-scatter contamination, but is it related to the issue reported here? |
@plt109 did you just publicly admit to your MS woes? ;) |
Works fine, have to assign call |
Sorry, I missed this issue earlier. I can definitely imagine this is confusing, the documentation is not so great on this. If it helps:
However, I suppose that works too, if indeed it's done before the |
When using nestSpatialRateNRSource or standard flamedisx SpatialRateNRSource in the tutorial spatial_hist is a class attribute and not an instance attribute.
This is an issue for if we want multiple spatially varying sources with different distributions later on.
@robertsjames suggested you take a look @JelleAalbers
Cheers,
Josh
The text was updated successfully, but these errors were encountered: