forked from jaegertracing/jaeger
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[tracegen] Allow use of adaptive sampling (jaegertracing#5718)
## Which problem is this PR solving? - Part of jaegertracing#5717 ## Description of the changes - Add a new flag to tracegen to allow it to use `jaegerremotesampling` contrib module with OTEL SDK ## How was this change tested? - It's not actually working at the moment, the backend does not recognize the spans without sampling tags Signed-off-by: Yuri Shkuro <github@ysh.us>
- Loading branch information
1 parent
13c715b
commit 31e8ef9
Showing
4 changed files
with
45 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#!/bin/bash | ||
|
||
set -euf -o pipefail | ||
|
||
# This script is currently a placeholder. | ||
|
||
# Commands to run integration test: | ||
# SAMPLING_STORAGE_TYPE=memory SAMPLING_CONFIG_TYPE=adaptive go run -tags=ui ./cmd/all-in-one --log-level=debug | ||
# go run ./cmd/tracegen -adaptive-sampling=http://localhost:14268/api/sampling -pause=10ms -duration=60m | ||
|
||
# Check how strategy is changing | ||
# curl 'http://localhost:14268/api/sampling?service=tracegen' | jq . | ||
|
||
# Issues | ||
# - SDK does not report sampling probability in the tags the way Jaeger SDKs did | ||
# - Server probably does not recognize spans as having adaptive sampling without sampler info | ||
# - There is no way to modify target traces-per-second dynamically, must restart collector. |