Skip to content

Commit

Permalink
[ci] Validate that generated mocks are up to date (jaegertracing#5568)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- We want mockery version to be up to date with the generated files.
- jaegertracing#5563 upgrades mockery, but does not re-generate the files.

## Description of the changes
- Add a lint check to the workflow for protobuf

## How was this change tested?
- the step passed in the CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
  • Loading branch information
yurishkuro committed Jun 11, 2024
1 parent 4ec48d0 commit 5bb7cbb
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci-protogen-tests.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Protogen Validation
name: Generated Files Validation

on:
push:
Expand All @@ -16,7 +16,7 @@ permissions: # added using https://github.com/step-security/secure-workflows
contents: read

jobs:
protogen:
generated-files-check:
runs-on: ubuntu-latest
steps:
- name: Harden Runner
Expand All @@ -37,3 +37,6 @@ jobs:

- name: Verify Thrift types are up to date
run: make thrift && git diff --name-status --exit-code

- name: Verify Mockery types are up to date
run: make generate-mocks && git diff --name-status --exit-code

0 comments on commit 5bb7cbb

Please sign in to comment.