forked from jaegertracing/jaeger
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid git warnings on shallow checkout (jaegertracing#5455)
## Which problem is this PR solving? Many of GH workflows are logging warnings like this: ``` Run make install-test-tools fatal: No names found, cannot describe anything. fatal: No names found, cannot describe anything. fatal: No names found, cannot describe anything. fatal: No names found, cannot describe anything. fatal: No names found, cannot describe anything. ``` This is because we typically do a shallow checkout of the repo without tags. ## Description of the changes - Check for shallow checkout and don't run `git describe` ## How was this change tested? - CI `lint`: no warnings logged when calling `make` ``` $ make echo-version GIT_CLOSEST_TAG=0.0.0 ``` Signed-off-by: Yuri Shkuro <github@ysh.us>
- Loading branch information
1 parent
acad244
commit 7df05d9
Showing
2 changed files
with
15 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters