Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation not showing on About page #361

Open
wants to merge 79 commits into
base: main
Choose a base branch
from
Open

Fix animation not showing on About page #361

wants to merge 79 commits into from

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Oct 6, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR fixes the issue where the animation on the About page is not visible when the page is first loaded. The animation is currently triggered too early, before the component is mounted to the DOM. This PR moves the animation function calls into the useEffect hook to ensure they are executed after the component is mounted.

Summary of Changes

  • Modified src/components/About/About.tsx to move the animation function call into the useEffect hook.
  • Modified src/components/About/AboutCard.tsx to move the animation function call into the useEffect hook.
  • Modified src/components/About/Github.tsx to move the animation function call into the useEffect hook.
  • Modified src/components/About/OtherSkills.tsx to move the animation function call into the useEffect hook.
  • Modified src/components/About/Techstack.tsx to move the animation function call into the useEffect hook.
  • Modified src/components/About/Toolstack.tsx to move the animation function call into the useEffect hook.

Please review and merge these changes to fix the issue with the About page animation.

Fixes #182.

🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code to only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai sweep-ai bot added the sweep label Oct 6, 2023
@sweep-ai sweep-ai bot mentioned this pull request Oct 6, 2023
Open
@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portfolio ❌ Failed (Inspect) Apr 1, 2024 8:18am

@deepsource-autofix
style: format code with Prettier and StandardJS
6271c2c 
This commit fixes the style issues introduced in 86f57dd according to the output
from Prettier and StandardJS.

Details: #361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sweep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a delay or smth other when first accessing the about page for showing the animation
0 participants