fix: remove dangling literals

FlickerSoul · Nov 2, 2023 · 8236d8b · 8236d8b
1 parent 051b3b7
commit 8236d8b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/gapper/core/file_handlers.py b/src/gapper/core/file_handlers.py
@@ -5,6 +5,7 @@
 from zipfile import ZipFile
 
 from gapper.core.tester import Tester
+from gapper.gradescope.vars import DEFAULT_TESTER_PICKLE_NAME
 
 
 class AutograderZipper:
@@ -47,9 +48,9 @@ def _copy_gs_setup(self, zip_file: ZipFile) -> None:
 
     def _copy_tester_pickle(self, zip_file: ZipFile) -> None:
         with TemporaryDirectory() as temp_dir:
-            path = Path(temp_dir) / "tester.pckl"
+            path = Path(temp_dir) / DEFAULT_TESTER_PICKLE_NAME
             self._tester.dump_to(path)
-            zip_file.write(path, arcname="tester.pckl")
+            zip_file.write(path, arcname=DEFAULT_TESTER_PICKLE_NAME)
 
     def zip_file_path(self, path: Path, zip_file: ZipFile, root: Path) -> None:
         """Zip a file or folder.

diff --git a/src/gapper/gradescope/vars.py b/src/gapper/gradescope/vars.py
@@ -1,8 +1,10 @@
 from pathlib import Path
 
+DEFAULT_TESTER_PICKLE_NAME = "tester.pckl"
+
 AUTOGRADER_ROOT = Path("/autograder")
 AUTOGRADER_SRC = AUTOGRADER_ROOT / "source"
 AUTOGRADER_SUBMISSION = AUTOGRADER_ROOT / "submission"
 AUTOGRADER_METADATA = AUTOGRADER_ROOT / "submission_metadata.json"
 AUTOGRADER_OUTPUT = AUTOGRADER_ROOT / "results/results.json"
-AUTOGRADER_TESTER_PICKLE = AUTOGRADER_SRC / "tester.pckl"
+AUTOGRADER_TESTER_PICKLE = AUTOGRADER_SRC / DEFAULT_TESTER_PICKLE_NAME