Merge pull request #55 from Fliplet/fix-ID-2640

ID-2640 [Fix] Ensures click listeners are only fired once for each widget version
Fliplet · Oct 10, 2022 · 1f0ae0a · 1f0ae0a
2 parents c3a1fd1 + 9e7cfb6
commit 1f0ae0a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/build.html b/build.html
@@ -1,5 +1,5 @@
 {{#if items.length}}
-<div data-list-id="{{id}}" data-filter-id="{{id}}" data-list-uuid="{{uuid}}" class="list list-default {{#if swipeToSave}}list-swipe-save{{/if}}">
+<div data-list-1-0-1-id="{{id}}" data-filter-id="{{id}}" data-list-uuid="{{uuid}}" class="list list-default {{#if swipeToSave}}list-swipe-save{{/if}}">
   {{#if swipeToSave}}
   <div class="filter-wrapper">
     <ul class="list-save-filter">

diff --git a/js/build.js b/js/build.js
@@ -1,19 +1,18 @@
-Fliplet.Widget.instance('list', function(data) {
+Fliplet.Widget.instance('list-1-0-1', function(data) {
   var $container = $(this);
   var _this = this;
 
   $container.find('.linked[data-list-item-id]').click(function(event) {
     event.preventDefault();
 
-    var $container = $(this);
+    var $listItem = $(this);
 
-    if ($container.parents('.list-swipe.swiping').length) {
+    if ($listItem.parents('.list-swipe.swiping').length) {
       return;
     }
 
-    var data = Fliplet.Widget.getData($container.parents('[data-list-id]').attr('data-list-id'));
     var itemData = _.find(data.items, {
-      id: $container.attr('data-list-item-id')
+      id: $listItem.attr('data-list-item-id')
     });
 
     if (!_.isUndefined(itemData) && (!_.isUndefined(itemData.linkAction) && !_.isEmpty(itemData.linkAction))) {
@@ -28,7 +27,7 @@ Fliplet.Widget.instance('list', function(data) {
 
     if (data.swipeToSave) {
       window.ui = window.ui || {};
-      window.ui['swipeSavedList' + $container.attr('data-list-uuid')] = new SwipeSaveList(_this, {
+      window.ui['swipeSavedList' + data.uuid] = new SwipeSaveList(_this, {
         savedListLabel: swipeToSaveLabel
       });
     }