Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes and support for the new NIBBS BVN verification flow #145

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

Dekunledev
Copy link
Contributor

  • Added NIBBS BVN verification flow.
  • Added unit tests for the new BVN verification flow, transaction fees, and Card Collection into subaccounts.
  • Added 'subaccounts' as an optional body parameter for card charge and PWBT (Pay with Bank Transfer).
  • Fixed "URL Not Found" Error returned from Validate Bill Service method.
  • Fixed "Invalid currency provided" Error returned from the Transaction fees method.

Copy link

gitguardian bot commented Feb 19, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8556160 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556161 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556162 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556162 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556163 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556164 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556165 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
8556166 Triggered Generic High Entropy Secret 00a2b47 test/rave.payment-plan.test.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@corneliusyaovi corneliusyaovi merged commit 6ff590d into Flutterwave:dev Feb 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants