Fix test and number underflow

FluxCapacitor2 · Jul 21, 2024 · c356e35 · c356e35
1 parent dd5e831
commit c356e35
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/app/server/pagination.go b/app/server/pagination.go
@@ -19,7 +19,7 @@ func urlWithParam(url *url.URL, key string, value string) string {
 	return url.String()
 }
 
-func createPagination(url *url.URL, page uint32, pageCount uint32) []resultsPage {
+func createPagination(url *url.URL, page int32, pageCount int32) []resultsPage {
 	pages := make([]resultsPage, 0, int(math.Min(12, float64(pageCount+4))))
 
 	if pageCount == 1 {
@@ -40,8 +40,8 @@ func createPagination(url *url.URL, page uint32, pageCount uint32) []resultsPage
 	})
 
 	startIndex := page - 5
-
 	endIndex := page + 5
+
 	if startIndex < 0 {
 		startIndex = 0
 	}

diff --git a/app/server/pagination_test.go b/app/server/pagination_test.go
@@ -15,8 +15,8 @@ func TestPagination(t *testing.T) {
 	}
 
 	table := []struct {
-		page      int
-		pageCount int
+		page      int32
+		pageCount int32
 		want      []resultsPage
 	}{
 		// When the cursor is at the start
@@ -78,7 +78,7 @@ func TestPagination(t *testing.T) {
 	for i, testCase := range table {
 		actual := createPagination(url, testCase.page, testCase.pageCount)
 		if !reflect.DeepEqual(testCase.want, actual) {
-			t.Fatalf("test case %v failed: wanted %v, got %+v", i+1, testCase.want, actual)
+			t.Fatalf("test case %v failed: wanted %+v, got %+v", i+1, testCase.want, actual)
 		}
 	}
 }
diff --git a/app/server/server.go b/app/server/server.go
@@ -189,11 +189,11 @@ func renderTemplateWithResults(db database.Database, config *config.Config, req
 	}
 
 	ceil := math.Ceil(float64(*total) / 10.0)
-	pageCount := uint32(math.Min(ceil, math.MaxUint32))
+	pageCount := int32(math.Min(ceil, math.MaxInt32))
 	if pageCount < 1 {
 		pageCount = 1
 	}
-	pages := createPagination(req.URL, uint32(page), pageCount)
+	pages := createPagination(req.URL, int32(page), pageCount)
 
 	mappedResults := make([]searchResult, len(results))
 	for i, res := range results {