Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pretrain to pretrained? #224

Open
CarloLucibello opened this issue Apr 23, 2023 · 2 comments
Open

change pretrain to pretrained? #224

CarloLucibello opened this issue Apr 23, 2023 · 2 comments

Comments

@CarloLucibello
Copy link
Member

CarloLucibello commented Apr 23, 2023

Should we have

VGG(11, pretrained=true)

instead of

VGG(11, pretrain=true)

The latter seems a command...

@CarloLucibello
Copy link
Member Author

CarloLucibello commented Apr 23, 2023

Even better, as in torchvision we could have a weights argument instead where we can pass more specific values, in case of multiple pretraining options:

VGG(11, weights="IMAGENET1K_V1")

@darsnack
Copy link
Member

Yes the loading logic already supports that, and the plan was to move to that once we have multiple weight options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants