Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse tuples of nothing #26

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Collapse tuples of nothing #26

merged 1 commit into from
Jan 13, 2024

Conversation

devmotion
Copy link
Contributor

Zygote uses the convention that tuples of nothing are collapsed to a single nothing. However, currently this convention is not applied to @adjoints. The PR fixes this, as suggested in FluxML/Zygote.jl#1464 (comment).

ToucheSir added a commit to FluxML/Zygote.jl that referenced this pull request Oct 24, 2023
@ToucheSir
Copy link
Member

Thanks! Since most of the tests are on the Zygote side, I've opened FluxML/Zygote.jl#1466 with a copy of these changes to see what CI thinks. If everything looks good, will merge this.

@devmotion
Copy link
Contributor Author

Would be useful to add downstream tests with at least Zygote to this repo IMO.

This was referenced Oct 24, 2023
@roflmaostc
Copy link

Can this be merged? I encountered a similar error but not sure...

@ToucheSir
Copy link
Member

See FluxML/Zygote.jl#1466 (comment). We need to do some tests on the user-facing interface in Zygote, then this can be merged. I haven't decided whether it should be a breaking change or not.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results in FluxML/Zygote.jl#1495 look good, time to merge and tag :)

@ToucheSir ToucheSir merged commit acd86a9 into FluxML:master Jan 13, 2024
6 checks passed
@devmotion devmotion deleted the patch-1 branch January 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants