From aeb3b01c90e4d3e85b007482c4859f53cd79db87 Mon Sep 17 00:00:00 2001
From: "dogan.ay" <65234588+DayTF@users.noreply.github.com>
Date: Wed, 19 Jul 2023 10:30:03 +0200
Subject: [PATCH] fix: throw error on null sequelize models (#768)

---
 packages/datasource-sequelize/src/datasource.ts           | 1 +
 .../datasource-sequelize/test/datasource.unit.test.ts     | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/packages/datasource-sequelize/src/datasource.ts b/packages/datasource-sequelize/src/datasource.ts
index e6683e0b74..d155a04b73 100644
--- a/packages/datasource-sequelize/src/datasource.ts
+++ b/packages/datasource-sequelize/src/datasource.ts
@@ -16,6 +16,7 @@ export default class SequelizeDataSource extends BaseDataSource<SequelizeCollect
     super();
 
     if (!sequelize) throw new Error('Invalid (null) Sequelize instance.');
+    if (!sequelize.models) throw new Error('Invalid (null) Sequelize models.');
 
     this.sequelize = sequelize;
 
diff --git a/packages/datasource-sequelize/test/datasource.unit.test.ts b/packages/datasource-sequelize/test/datasource.unit.test.ts
index 90f1f44a36..e1907cdcc9 100644
--- a/packages/datasource-sequelize/test/datasource.unit.test.ts
+++ b/packages/datasource-sequelize/test/datasource.unit.test.ts
@@ -3,10 +3,16 @@ import { Sequelize } from 'sequelize';
 import { SequelizeCollection, SequelizeDataSource } from '../src';
 
 describe('SequelizeDataSource', () => {
-  it('should fail to instanciate without a Sequelize instance', () => {
+  it('should fail to instantiate without a Sequelize instance', () => {
     expect(() => new SequelizeDataSource(null)).toThrow('Invalid (null) Sequelize instance.');
   });
 
+  it('should fail to instantiate without a Sequelize models defined', () => {
+    expect(() => new SequelizeDataSource({} as Sequelize)).toThrow(
+      'Invalid (null) Sequelize models.',
+    );
+  });
+
   it('should have no predefined collection', () => {
     expect(
       new SequelizeDataSource({ models: {} } as unknown as Sequelize).collections,