feat: add html block in action forms #1172

EnkiP · 2024-09-13T07:55:24Z

Definition of Done

CU-86c097bhw

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

forest-bot · 2024-09-13T07:55:28Z

Task linked: CU-86c097bhw Story #2 - Add "htmlBlock" layout element

Thenkei · 2024-09-13T13:53:07Z

packages/_example/src/forest/customizations/card.ts

+        return resultBuilder.success('ok', {
+          html: `test<script type="text/javascript">alert("test")</script>`,
+        });


Thenkei · 2024-09-13T13:53:23Z

packages/_example/src/forest/customizations/card.ts

@@ -27,6 +29,18 @@ export default (collection: CardCustomizer) =>
          component: 'Separator',
          if: ctx => ctx.formValues.first_name?.[0] === 'test',
        },
+        {


packages/datasource-customizer/src/decorators/actions/types/fields.ts

Thenkei · 2024-09-13T13:56:02Z

packages/datasource-customizer/src/decorators/actions/types/fields.ts

+};
+
+export type DynamicLayoutElement<Context = unknown> =
+  | DynamicLayoutElementBase<Context>


Suggested change

| DynamicLayoutElementBase<Context>

Thenkei · 2024-09-13T13:57:01Z

packages/datasource-toolkit/src/interfaces/action.ts

@@ -271,7 +271,7 @@ export type ActionFieldWidget =
  | 'FilePicker'
  | 'JsonEditor';

-type LayoutElementComponentType = 'Input' | 'Separator';
+type LayoutElementComponentType = 'Input' | 'Separator' | 'HtmlBlock';


Same as in the frontend. You can improve types by infering LayoutElementComponentType -> ActionLayoutElement['component'].

jbarreau

LGTM 👍

codeclimate · 2024-09-17T14:09:52Z

Code Climate has analyzed commit 4e630f0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5% (0.0% change).

View more on Code Climate.

## [1.8.47](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.8.46...example@1.8.47) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

# [1.43.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.42.0...@forestadmin/agent@1.43.0) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:14Z

🎉 This PR is included in version 1.3.16 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.49.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.48.0...@forestadmin/datasource-customizer@1.49.0) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:20Z

🎉 This PR is included in version 1.8.47 🎉

The release is available on example@1.8.47

Your semantic-release bot 📦🚀

## [1.1.27](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.26...@forestadmin/datasource-dummy@1.1.27) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

## [1.7.16](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.7.15...@forestadmin/datasource-mongoose@1.7.16) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

## [1.3.33](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.3.32...@forestadmin/datasource-replica@1.3.33) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:29Z

🎉 This PR is included in version 1.43.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.9.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.9.3...@forestadmin/datasource-sequelize@1.9.4) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

## [1.14.20](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.19...@forestadmin/datasource-sql@1.14.20) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:38Z

🎉 This PR is included in version 1.49.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.36.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.35.0...@forestadmin/datasource-toolkit@1.36.0) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

## [1.11.11](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.11.10...@forestadmin/forest-cloud@1.11.11) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:47Z

🎉 This PR is included in version 1.1.27 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.29.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.28.0...@forestadmin/forestadmin-client@1.29.0) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

## [1.3.87](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.86...@forestadmin/plugin-aws-s3@1.3.87) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:53Z

🎉 This PR is included in version 1.7.16 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.0.98](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.0.97...@forestadmin/plugin-export-advanced@1.0.98) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:31:59Z

🎉 This PR is included in version 1.3.33 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.2.13](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.2.12...@forestadmin/plugin-flattener@1.2.13) (2024-09-17) ### Features * add html block in action forms ([#1172](#1172)) ([4c67ccd](4c67ccd))

forest-bot · 2024-09-17T14:32:08Z

🎉 This PR is included in version 1.9.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Enki Pontvianne added 5 commits September 12, 2024 10:42

feat: add separator in action forms

b628f49

fix: schema serialization

b099557

fix: default values

7ccb8f6

test: add tests

e50894e

feat: add html block in action forms

17fc6d5

EnkiP changed the title ~~Feat/add html block in action forms~~ feat: add html block in action forms Sep 13, 2024

EnkiP changed the base branch from main to feat/add-separator-in-action-forms September 13, 2024 07:56

Thenkei reviewed Sep 13, 2024

View reviewed changes

packages/datasource-customizer/src/decorators/actions/types/fields.ts Show resolved Hide resolved

Thenkei reviewed Sep 13, 2024

View reviewed changes

Enki Pontvianne added 6 commits September 13, 2024 16:15

fix: remove example

ae374af

fix: review (comment & remove useless export)

e3342ee

fix: example

95e6d0c

fix: remove action in example

be5a13c

fix: remove action in example

04bdec9

fix: review

07634ea

Base automatically changed from feat/add-separator-in-action-forms to main September 17, 2024 13:18

Enki Pontvianne added 2 commits September 17, 2024 15:21

fix: merge main

fb51510

fix: types

cae0d51

jbarreau approved these changes Sep 17, 2024

View reviewed changes

test: add test

4e630f0

jbarreau approved these changes Sep 17, 2024

View reviewed changes

EnkiP merged commit 4c67ccd into main Sep 17, 2024
22 checks passed

EnkiP deleted the feat/add-html-block-in-action-forms branch September 17, 2024 14:18

forest-bot added the released label Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add html block in action forms #1172

feat: add html block in action forms #1172

EnkiP commented Sep 13, 2024

forest-bot commented Sep 13, 2024

Thenkei Sep 13, 2024

EnkiP Sep 13, 2024

Thenkei Sep 13, 2024

Thenkei Sep 13, 2024

Thenkei Sep 13, 2024

jbarreau left a comment

codeclimate bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

feat: add html block in action forms #1172

feat: add html block in action forms #1172

Conversation

EnkiP commented Sep 13, 2024

Definition of Done

General

Security

forest-bot commented Sep 13, 2024

Thenkei Sep 13, 2024

Choose a reason for hiding this comment

EnkiP Sep 13, 2024

Choose a reason for hiding this comment

Thenkei Sep 13, 2024

Choose a reason for hiding this comment

Thenkei Sep 13, 2024

Choose a reason for hiding this comment

Thenkei Sep 13, 2024

Choose a reason for hiding this comment

jbarreau left a comment

Choose a reason for hiding this comment

codeclimate bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024

forest-bot commented Sep 17, 2024