feat: add row in action forms #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86c097bm3 Story #3 - Add "row" layout element |
added 2 commits
September 13, 2024 16:13
EnkiP
force-pushed
the
feat/add-row-in-action-forms
branch
from
3762841
to
1953b49
Compare
|
Code Climate has analyzed commit 79f503b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.0% (98% is the threshold). This pull request will bring the total coverage in the repository to 97.5% (0.0% change). View more on Code Climate. |
Thenkei
reviewed
Sep 18, 2024
| return element; | ||
| } | ||
|
|
||
| allFields.push(element); |
There was a problem hiding this comment.
😢 Mutating function parameters. 😬
Thenkei
reviewed
Sep 18, 2024
Comment on lines
-136
to
-144
| { | ||
| type: 'Layout', | ||
| component: 'Separator', | ||
| }, | ||
| { | ||
| type: 'Layout', | ||
| component: 'HtmlBlock', | ||
| content: 'some text content', | ||
| }, |
Thenkei
reviewed
Sep 18, 2024
| field[subElementsKey] = await handler(field[subElementsKey] || []); | ||
| } | ||
|
|
||
| private async copyFields(fields: DynamicFormElement[]) { |
There was a problem hiding this comment.
I think this need a little explaination.
Because,
- it copy the fields but also do crazy things (async + call handler on subfields) ?
- I don't understand the need of async in there
There was a problem hiding this comment.
Oh ok, you use this mechanism to do async work dropDefault (= compute default value) , dropIfs (= remove field that have if: false), ...
There was a problem hiding this comment.
But style copyFields should be sync.
There was a problem hiding this comment.
You can define two versions of executeOnSubFields
Thenkei
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
- ✅ Code review 💪 (some tiny improvments will come in a refactor PR)
- ✅ Use pure functions when possible
- ✅ Performance concerns
- ✅ The PR tackle one subject only
- ✅ Automatic tests
- ✅ Unit tests
- ✅ Integration tests
- ✅ Manual tests
- ✅ PR title
- ❔ PR linked to the clickup task
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
# [1.9.0](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.8.47...example@1.9.0) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
# [1.44.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.43.0...@forestadmin/agent@1.44.0) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
|
🎉 This PR is included in version 1.3.17 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
# [1.50.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.49.0...@forestadmin/datasource-customizer@1.50.0) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.1.28](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.27...@forestadmin/datasource-dummy@1.1.28) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.7.17](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.7.16...@forestadmin/datasource-mongoose@1.7.17) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.3.34](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.3.33...@forestadmin/datasource-replica@1.3.34) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.9.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.9.4...@forestadmin/datasource-sequelize@1.9.5) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
|
🎉 This PR is included in version 1.44.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.14.21](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.20...@forestadmin/datasource-sql@1.14.21) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
# [1.37.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.36.0...@forestadmin/datasource-toolkit@1.37.0) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.11.12](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.11.11...@forestadmin/forest-cloud@1.11.12) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
|
🎉 This PR is included in version 1.50.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
# [1.30.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.29.0...@forestadmin/forestadmin-client@1.30.0) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.3.88](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.87...@forestadmin/plugin-aws-s3@1.3.88) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.0.99](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.0.98...@forestadmin/plugin-export-advanced@1.0.99) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
|
🎉 This PR is included in version 1.1.28 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Sep 18, 2024
## [1.2.14](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.2.13...@forestadmin/plugin-flattener@1.2.14) (2024-09-18) ### Features * add row in action forms ([#1173](#1173)) ([8770699](8770699))
|
🎉 This PR is included in version 1.7.17 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
CU-86c097bm3
General
Security