feat: add optional id in action form fields

packages/_example/src/forest/customizations/card.ts

@@ -88,6 +88,11 @@ export default (collection: CardCustomizer) =>
           defaultValue: 80,
           if: ctx => ['Gold'].includes(ctx.formValues.Plan),
         },
+        {
+          type: 'Number',
+          id: 'test-price',
+          label: 'price',
+        },
         { type: 'Layout', component: 'Separator' },
         { type: 'Layout', component: 'HtmlBlock', content: '<h3>constraints:</h3>' },
         {

packages/agent/src/utils/forest-schema/action-values.ts

@@ -19,7 +19,7 @@ export default class ForestValueConverter {
     const data = {};
 
     for (const [key, value] of Object.entries(rawData)) {
-      const field = fields.find(f => f.label === key);
+      const field = fields.find(f => f.id === key);
 
       // Skip fields from the default form
       if (!SchemaGeneratorActions.defaultFields.map(f => f.field).includes(key)) {

packages/agent/src/utils/forest-schema/generator-actions.ts

@@ -29,6 +29,7 @@ export default class SchemaGeneratorActions {
   static defaultFields: ForestServerActionField[] = [
     {
       field: 'Loading...',
+      label: 'Loading...',
       type: 'String',
       isReadOnly: true,
       defaultValue: 'Form is loading',
@@ -98,10 +99,12 @@ export default class SchemaGeneratorActions {
 
   /** Build schema for given field */
   static buildFieldSchema(dataSource: DataSource, field: ActionField): ForestServerActionField {
-    const { label, description, isRequired, isReadOnly, watchChanges, type } = field;
-    const output = { description, isRequired, isReadOnly } as Record<string, unknown>;
+    const { id, label, description, isRequired, isReadOnly, watchChanges, type } = field;
+    const output = { field: id, label, description, isRequired, isReadOnly } as Record<
+      string,
+      unknown
+    >;
 
-    output.field = label;
     output.value = ForestValueConverter.valueToForest(field, field.value);
 
     if (watchChanges) output.hook = 'changeHook';
@@ -215,7 +218,7 @@ export default class SchemaGeneratorActions {
     return {
       type: 'Layout',
       component: 'Input',
-      fieldId: element.label,
+      fieldId: element.id,
     };
   }
 }

packages/agent/test/routes/modification/action/action.test.ts

@@ -299,7 +299,9 @@ describe('ActionRoute', () => {
             actions: { MySingleAction: { scope: 'Single' } },
             fields: { id: factories.columnSchema.uuidPrimaryKey().build() },
           },
-          getForm: jest.fn().mockResolvedValue([{ type: 'String', label: 'firstname' }]),
+          getForm: jest
+            .fn()
+            .mockResolvedValue([{ type: 'String', label: 'firstname', id: 'firstname' }]),
           execute: jest.fn().mockResolvedValue({
             type: 'Error',
             message: 'the result does not matter',
@@ -574,7 +576,7 @@ describe('ActionRoute', () => {
       );
 
       expect(context.response.body).toEqual({
-        fields: [{ field: 'firstname', type: 'String' }],
+        fields: [{ field: 'firstname', type: 'String', label: 'firstname' }],
         layout: [],
       });
     });
@@ -583,15 +585,15 @@ describe('ActionRoute', () => {
       const context = createMockContext(baseContext);
 
       dataSource.getCollection('books').getForm = jest.fn().mockResolvedValue([
-        { type: 'String', label: 'firstname' },
+        { type: 'String', id: 'firstname', label: 'firstname' },
         { type: 'Layout', component: 'Separator' },
       ]);
 
       // @ts-expect-error: test private method
       await route.handleHook(context);
 
       expect(context.response.body).toEqual({
-        fields: [{ field: 'firstname', type: 'String' }],
+        fields: [{ field: 'firstname', type: 'String', label: 'firstname' }],
         layout: [{ component: 'input', fieldId: 'firstname' }, { component: 'separator' }],
       });
     });
@@ -641,7 +643,7 @@ describe('ActionRoute', () => {
       );
 
       expect(context.response.body).toEqual({
-        fields: [{ field: 'firstname', type: 'String' }],
+        fields: [{ field: 'firstname', type: 'String', label: 'firstname' }],
         layout: [],
       });
     });