fix: required fields are not required in schema when they have default values #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 965a082 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (98% is the threshold). This pull request will bring the total coverage in the repository to 97.5%. View more on Code Climate. |
realSpok
changed the title
Thenkei
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
- ✅ Code review - As I said we need an additional fix on top of this one to propose a clean experience when it come to record creation with a field default value being a function. So let's merge that one and add the additional way to know when there's a defaultValueFunction. 🚀
- ✅ The PR tackle one subject only
- ✅ Automatic tests
- ✅ Manual tests
- ✅ PR title
- ✅ PR linked to the clickup task
realSpok
deleted the
fix/fields-required-are-required-in-schema-even-if-they-have-default-values
branch
forest-bot
added a commit
that referenced
this pull request
Oct 9, 2024
## [1.11.3](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.11.2...example@1.11.3) (2024-10-09) ### Bug Fixes * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
|
🎉 This PR is included in version 1.11.23 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Oct 9, 2024
## [1.4.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.4.3...@forestadmin/datasource-replica@1.4.4) (2024-10-09) ### Bug Fixes * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
forest-bot
added a commit
that referenced
this pull request
Oct 9, 2024
## [1.10.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.2...@forestadmin/datasource-sequelize@1.10.3) (2024-10-09) ### Bug Fixes * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))
forest-bot
added a commit
that referenced
this pull request
Oct 9, 2024
## [1.14.29](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.28...@forestadmin/datasource-sql@1.14.29) (2024-10-09) ### Bug Fixes * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))
|
🎉 This PR is included in version 1.11.3 🎉 The release is available on Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.4 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.10.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.14.29 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Oct 9, 2024
## [1.50.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.50.0...@forestadmin/agent@1.50.1) (2024-10-09) ### Bug Fixes * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
|
🎉 This PR is included in version 1.50.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.55.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.55.0...@forestadmin/datasource-customizer@1.55.1) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.1.36](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.35...@forestadmin/datasource-dummy@1.1.36) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.8.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.3...@forestadmin/datasource-mongoose@1.8.4) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.42.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.42.0...@forestadmin/datasource-toolkit@1.42.1) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))
|
🎉 This PR is included in version 1.3.24 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.34.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.34.0...@forestadmin/forestadmin-client@1.34.1) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.4.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.3...@forestadmin/plugin-aws-s3@1.4.4) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.1.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.6...@forestadmin/plugin-export-advanced@1.1.7) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
forest-bot
added a commit
that referenced
this pull request
Oct 10, 2024
## [1.3.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.3.3...@forestadmin/plugin-flattener@1.3.4) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.forestadmin.com/t/migration-to-forestadmin-agent-problems-with-not-null-default-value-fields/7475
#86c0fy2u0
Definition of Done
General
Security