Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add caller ip in action context.caller.request.ip #1196

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

EnkiP
Copy link
Member

@EnkiP EnkiP commented Oct 18, 2024

#86c0qat37

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@EnkiP EnkiP force-pushed the feat/add-ip-in-action-caller branch from c449707 to ebc92ba Compare October 18, 2024 08:53
@EnkiP EnkiP force-pushed the feat/add-ip-in-action-caller branch 2 times, most recently from e512c92 to 1b3564a Compare October 18, 2024 11:46
@EnkiP EnkiP force-pushed the feat/add-ip-in-action-caller branch from 1b3564a to abf22c3 Compare October 18, 2024 12:01
@@ -140,7 +141,7 @@ export default class QueryStringParser {
QueryStringParser.VALID_TIMEZONES.add(timezone);
}

return { ...context.state.user, timezone, requestId: uuidv4() };
return { ...context.state.user, timezone, requestId: uuidv4(), request: { ip } };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it.

Copy link
Member

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codeclimate bot commented Oct 18, 2024

Code Climate has analyzed commit abf22c3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5%.

View more on Code Climate.

@EnkiP EnkiP merged commit 25aa5b8 into main Oct 18, 2024
22 checks passed
@EnkiP EnkiP deleted the feat/add-ip-in-action-caller branch October 18, 2024 12:12
forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.11.7](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.11.6...example@1.11.7) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
# [1.51.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.50.3...@forestadmin/agent@1.51.0) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.55.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.55.1...@forestadmin/datasource-customizer@1.55.2) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.11.27 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.1.37](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.36...@forestadmin/datasource-dummy@1.1.37) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.3.25](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongo@1.3.24...@forestadmin/datasource-mongo@1.3.25) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.11.7 🎉

The release is available on example@1.11.7

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.8.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.4...@forestadmin/datasource-mongoose@1.8.5) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
# [1.5.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.4.5...@forestadmin/datasource-replica@1.5.0) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.10.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.4...@forestadmin/datasource-sequelize@1.10.5) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.14.31](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.30...@forestadmin/datasource-sql@1.14.31) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
# [1.43.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.42.1...@forestadmin/datasource-toolkit@1.43.0) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.51.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.34.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.34.1...@forestadmin/forestadmin-client@1.34.2) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.4.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.4...@forestadmin/plugin-aws-s3@1.4.5) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.55.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 18, 2024
## [1.3.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.3.4...@forestadmin/plugin-flattener@1.3.5) (2024-10-18)

### Bug Fixes

* fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9))
* **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764))
* **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

### Features

* add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.37 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.25 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.5.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.10.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.14.31 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.43.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.34.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants