-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code bugs. #505
Code bugs. #505
Conversation
From Idea: |
…ile with empty objects. Improves the use of memory and CPUs
public final class EmptyHelper { | ||
private EmptyHelper() {} | ||
|
||
public static final String EMPTY_STRING = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably overkill, I'd be surprised if the JVM does not have some kind of optimization for the empty string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Probably you are right.
But now I used StringUtils.Empty (as you can see in #504)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds good.
At first i thought that something is broken, but after some tests I realized that everything work (flower image sizes). So calculation can be removed.
Fuchsia has one section.
Binnie/botany/src/main/java/binnie/botany/genetics/EnumFlowerType.java
Line 50 in 4946c9d
Foxglove - two.
Binnie/botany/src/main/java/binnie/botany/genetics/EnumFlowerType.java
Line 37 in 4946c9d