Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aragog constant #235

Merged
merged 19 commits into from
Oct 28, 2024
Merged

Aragog constant #235

merged 19 commits into from
Oct 28, 2024

Conversation

lsoucasse
Copy link
Member

This work introduces Aragog as an alternative module for interior modelling.

It uses constant physical properties and runs fine athough the coupled results seem to not behave properly, see here.

I suggest we create new issues to debug coupled behaviour and expand from this current state (add config parameters, use look up tables, plot results).

@lsoucasse lsoucasse linked an issue Oct 25, 2024 that may be closed by this pull request
@lsoucasse
Copy link
Member Author

I am off next week so do not hesitate to change/approve/merge in my absence @planetmariana @timlichtenberg . I also add you @nichollsh as reviewer as you already managed to run this branch.

@timlichtenberg
Copy link
Collaborator

Thanks Laurent! All three of us @planetmariana @nichollsh and me should have a look through this and add a review. Once that is done, we can merge it in the next days.

@nichollsh
Copy link
Contributor

This is what I get from the dummy config when replacing the dummy interior with aragog. I think this is generally looking okay - the planet at least cools down and the melt fraction decreases.

plot_global_log

Copy link
Contributor

@nichollsh nichollsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I am happy for this to be merged. Nice work @lsoucasse. I agree that the next steps of the implementation can be handled by another PR.

@nichollsh nichollsh merged commit 3913922 into main Oct 28, 2024
5 checks passed
@nichollsh nichollsh deleted the aragog-constant branch October 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce support for aragog interior model
3 participants