-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aragog constant #235
Aragog constant #235
Conversation
I am off next week so do not hesitate to change/approve/merge in my absence @planetmariana @timlichtenberg . I also add you @nichollsh as reviewer as you already managed to run this branch. |
Thanks Laurent! All three of us @planetmariana @nichollsh and me should have a look through this and add a review. Once that is done, we can merge it in the next days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I am happy for this to be merged. Nice work @lsoucasse. I agree that the next steps of the implementation can be handled by another PR.
This work introduces Aragog as an alternative module for interior modelling.
It uses constant physical properties and runs fine athough the coupled results seem to not behave properly, see here.
I suggest we create new issues to debug coupled behaviour and expand from this current state (add config parameters, use look up tables, plot results).