Tests using physical simulations #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an from dummy run
lsoucasse
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
This is really great! Thanks @nichollsh.
We should consider to extend this test to a resume simulation for a later stage of planet evolution (again, for a couple of iterations). It will not increase the coverage but check code behaviour in another range of parameters.
|
Yes I definitely agree. I think particularly once we have also looked into #193. |
|
Thanks @lsoucasse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have tests using the Dummy simulations. This checks that the module coupling works okay and the dummy modules are working.
It is absolutely necessary to add tests for the physical modules. This PR introduces some initial tests for these, although they will surely be subject to change in the future. It runs PROTEUS with JANUS+Aragog+MORS+CALLIOPE for a few model steps. It does not run until convergence as this would take too long. Workflow runtime is about 5 minutes. Closes #237.
This increases the coverage from 45% to 59%. We could get this to ~65% if we included an AGNI test, but this would probably be quite slow.
Implementing these physical tests required adding installation steps for SOCRATES and Aragog to the CI workflow. These use caching to speed things up.
Includes a few bug fixes:
GitHub records that a lot of files were changed, but most of these are changes to the test data. Apologies for the many random commits - it took some work to get the CI workflow working properly. The key thing with this is the order in which the modules are checked-out.