Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config compatibility code #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove config compatibility code #251

wants to merge 1 commit into from

Conversation

stefsmeets
Copy link
Contributor

Closes #245

@nichollsh
Copy link
Contributor

nichollsh commented Nov 7, 2024 •
edited
Loading

Thanks @stefsmeets. I'll have a look at this when I can.

Just FYI: the test failing is due to changes on the Aragog side that haven't been reflected in PROTEUS. It can be fixed by simply removing the line which sets the core_radius attribute in Aragog. There's a fix for this in Emma's escape branch and my hn/k218b branch.

Ideally we would pull Aragog from PyPI to prevent this kind of problem, but this isn't possible because Aragog doesn't have a hook set up for this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichollsh nichollsh Awaiting requested review from nichollsh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove config compatibility layer.
2 participants
@stefsmeets @nichollsh