Add a Fxuv function using mors tracks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsoucasse
approved these changes
Oct 17, 2024
|
Thanks for pointing this out, @lsoucasse . Do you think I should change the output to a scalar like the other functions, or leave it like that? Let me know what you think is the better option. |
No I think it is OK as it is. Again, it is convenient to compute all the values, because of the cost of the track generation. Just something to keep in mind. |
|
Ok thanks for the advice @lsoucasse ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the stellar files I added for the last pull request, I created a Fxuv_mors function. This function takes the stellar mass, the stellar rotation rate and the distance to the host star as arguments. It uses mors.Star() to load the evolution track of the star and return 2 arrays : the age of the star and the corresponding XUV flux. I wrote a small python script (test_fxuv_mors.py) to be sure it was working correctly.