Add Belarusan Cyrillic and Latin layouts #70

Belarusan · 2024-08-13T13:28:15Z

Created a Belarusan Cyrillic layout

What is it?

Bugfix
Feature
Codebase improvement

Description of the changes in your PR

Added Belarusan Cyrillic layout

Fixes the following issue(s)

Fixes Add Belarusan layout #67

Acknowledgement

I read the contribution guidelines.

Created a Belarusan Cyrillic layout

Added LANGUAGE_BELARUSIAN_CYRL -> getString(R.string.translation_belarusian)

Added strings for Belarusan Cyrillic layout

Added string for Belarusan Cyrillic layout

Update Context.kt

Update Constants.kt

Update SimpleKeyboardIME.kt

Aga-C

Thanks for contributing, it's really helpful when native/advanced speakers can provide us more keyboard layouts, even if they're not familiar with Android development.

I've added a few comments, because right now the app doesn't compile, but fixes are simple ones. Also, I have two additional questions:

In the original issue, you wrote that it's only Cyrillic layout for now. I'm not Belarusian speaker, but doesn't it only have Cyrillic alphabet? I mean, even if Belarusian native would like to write Latin characters, wouldn't English keyboard be enough? Just asking to make sure, whether it's really needed. For other languages with Cyrillic alphabet (like Russian or Ukrainian) we don't have a separate version.
Here's how the layout looks like. Please check if it's how you wanted it to look:

Aga-C · 2024-08-13T15:29:55Z

app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt

@@ -207,6 +207,7 @@ fun Context.getKeyboardLanguagesRadioItems(): ArrayList<RadioItem> {
 fun Context.getKeyboardLanguageText(language: Int): String {
    return when (language) {
        LANGUAGE_ARABIC -> getString(R.string.translation_arabic)
+        LANGUAGE_BELARUSIAN_CYRL -> getString(R.string.translation_belarusian)


This string doesn't exist. You should add it in Commons in https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/res/values/strings.xml. When creating a pull request in Commons, please mention that it's for this one.

Done: FossifyOrg/Commons#60

Thank you for your instructions!

Aga-C · 2024-08-13T15:30:43Z

app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt

@@ -439,6 +439,7 @@ class SimpleKeyboardIME : InputMethodService(), OnKeyboardActionListener, Shared
    private fun getKeyboardLayoutXML(): Int {
        return when (baseContext.config.keyboardLanguage) {
            LANGUAGE_ARABIC -> R.xml.keys_letters_arabic
+            LANGUAGE_BELARUSIAN_CYRL -> R.xml.keys_belarusian_cyrl


Suggested change

LANGUAGE_BELARUSIAN_CYRL -> R.xml.keys_belarusian_cyrl

LANGUAGE_BELARUSIAN_CYRL -> R.xml.keys_letters_belarusian_cyrl

Belarusan · 2024-08-14T08:15:03Z

Thanks for contributing, it's really helpful when native/advanced speakers can provide us more keyboard layouts, even if they're not familiar with Android development.

I've added a few comments, because right now the app doesn't compile, but fixes are simple ones. Also, I have two additional questions:

In the original issue, you wrote that it's only Cyrillic layout for now. I'm not Belarusian speaker, but doesn't it only have Cyrillic alphabet? I mean, even if Belarusian native would like to write Latin characters, wouldn't English keyboard be enough? Just asking to make sure, whether it's really needed. For other languages with Cyrillic alphabet (like Russian or Ukrainian) we don't have a separate version.

Here's how the layout looks like. Please check if it's how you wanted it to look:

Thank you very much!

The Belarusan language has two equivalent scripts: Cyrillic and Latin. Unlike Ukrainian and Russian, which use only Cyrillic, the Serbian language, for example, also has both scripts. Here is a bit more about Belarusan Latin: https://en.wikipedia.org/wiki/Belarusian_Latin_alphabet.

Many Belarusans use the Latin script today (I won't go into details). However, the English keyboard layout contains many symbols that can interfere with convenient writing in Belarusan Latin, and it lacks certain essential symbols, such as ŭ. In my opinion, a dedicated Latin layout would be a wonderful option for Belarusans.

————

Yes, the layout looks correct, but it would be better if it were more balanced. Is there any way to achieve what is shown in my image? (Please look at the bottom row with the letters)

upd: I tried changing the width of the Shift and Backspace keys to 14%, but I'm not sure how it looks (the image below was made in a graphics editor as an example).

Changed the width of the two keys

Aga-C · 2024-08-14T11:22:10Z

The Belarusan language has two equivalent scripts: Cyrillic and Latin. Unlike Ukrainian and Russian, which use only Cyrillic, the Serbian language, for example, also has both scripts. Here is a bit more about Belarusan Latin: https://en.wikipedia.org/wiki/Belarusian_Latin_alphabet.

Thanks for explaining! If so, it makes sense to have two separate keyboard layouts.

upd: I tried changing the width of the Shift and Backspace keys to 14%, but I'm not sure how it looks (the image below was made in a graphics editor as an example).

Now it looks like this:

Belarusan · 2024-08-14T13:11:23Z

Thanks for explaining! If so, it makes sense to have two separate keyboard layouts.

I made a Latin layout file. Should I create a separate pull request or add it to the existing one?

Now it looks like this:

Thank you! It looks just like I imagined. Perfect.

Aga-C · 2024-08-14T13:23:52Z

I made a Latin layout file. Should I create a separate pull request or add it to the existing one?

No need for a separate PR, you can add it here 🙂

Add a string for Belarusan Latin script and fixed for Cyrillic

Added two strings for Belarusan Latin script

Added a string for Belarusan Latin script and fixed for Cyrillic

Belarusan · 2024-08-14T16:14:24Z

I made a Latin layout file. Should I create a separate pull request or add it to the existing one?

No need for a separate PR, you can add it here 🙂

Thank you for the answer! It's done. I hope I did everything right 😬

tenextractor · 2024-08-16T10:39:57Z

@Belarusan For the Latin layout, wouldn't adding dedicated keys for the letters Ć Č Ł Ń Ś Š Ŭ Ź Ž be better? I have made a layout with dedicated keys in my keyboard.

Belarusan · 2024-08-17T07:43:12Z

@Belarusan For the Latin layout, wouldn't adding dedicated keys for the letters Ć Č Ł Ń Ś Š Ŭ Ź Ž be better? I have made a layout with dedicated keys in my keyboard.

Thank you for sharing. I didn't want to create anything new, so I focused on existing options. I added the symbols Ć, Č, Ł, Ń, Ś, Š, Ŭ, Ź, Ž, etc., to the popup. By the way, this approach is also used in Polish.

tenextractor · 2024-08-17T08:44:54Z

It does not need to be new, the letters can just be added above the existing layout. So something like this:

Ć Č Ź Ž Ń Ŭ Ś Š Ł ?
Q W E R T Y U I O P
A S D F G H J K L
⬆ Z X C V B N M ⌫

Belarusan · 2024-08-17T10:29:23Z

It does not need to be new, the letters can just be added above the existing layout. So something like this:
Ć Č Ź Ž Ń Ŭ Ś Š Ł ?
Q W E R T Y U I O P
A S D F G H J K L
⬆ Z X C V B N M ⌫

Thank you, I understand your point.

However, layouts are not just a random set of letters; they need to be systematic. For instance, the currently popular Cyrillic Belarusan layout „йцукен“ isn't actually a systematic one — it's simply a modified version of the Russian layout. That being said, I didn't want to take it upon myself to create something entirely new. This task should involve linguists, designers, and the wider community, not just me.

naveensingh · 2024-10-25T17:54:13Z

I tried to learn this language but I failed, miserably. I hope this works alright ;)

Belarusan · 2024-11-04T10:56:20Z

I tried to learn this language but I failed, miserably. I hope this works alright ;)

Thank you for your support! I'm happy to say that the layout works well. However, I noticed a problem with the Cyrillic layout popups due to my oversight. I’ve fixed it and submitted a Pull Request. I also made a small change to the Latin layout.

It's quite an impressive challenge to learn Belarusan! Unfortunately, there are not many good resources available for learning Belarusan as a foreign language. I hope that in the future, if you still have the desire to learn, better materials will become available.

Belarusan added 8 commits August 13, 2024 14:26

Create keys_letters_belarusian_cyrl.xml

ea7bc15

Created a Belarusan Cyrillic layout

Update Context.kt

f61eb2b

Added LANGUAGE_BELARUSIAN_CYRL -> getString(R.string.translation_belarusian)

Update Constants.kt

95f5e7b

Added strings for Belarusan Cyrillic layout

Update SimpleKeyboardIME.kt

40949e6

Added string for Belarusan Cyrillic layout

Merge pull request #2 from Belarusan/patch-2

c0c28c2

Update Context.kt

Merge pull request #3 from Belarusan/patch-3

6982305

Update Constants.kt

Merge pull request #4 from Belarusan/patch-4

97caa25

Update SimpleKeyboardIME.kt

Update Constants.kt

c6e9e42

Aga-C reviewed Aug 13, 2024

View reviewed changes

Updated Belarusan layout

26cc42b

Changed the width of the two keys

Belarusan added 4 commits August 14, 2024 18:00

Create keys_letters_belarusian_latn.xml

01763d9

Update Context.kt

9024c4d

Add a string for Belarusan Latin script and fixed for Cyrillic

Update Constants.kt

b7b412f

Added two strings for Belarusan Latin script

Update SimpleKeyboardIME.kt

b701be5

Added a string for Belarusan Latin script and fixed for Cyrillic

Belarusan changed the title ~~Add Belarusan Cyrillic layout~~ Add Belarusan Cyrillic and Latins layouts Aug 14, 2024

Belarusan changed the title ~~Add Belarusan Cyrillic and Latins layouts~~ Add Belarusan Cyrillic and Latin layouts Aug 14, 2024

naveensingh and others added 3 commits October 25, 2024 13:15

Merge branch 'main' into patch-1

6816cdf

Merge branch 'main' into patch-1

8189486

Add missing import statement

8b32527

naveensingh merged commit 67f18d5 into FossifyOrg:main Oct 25, 2024
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Belarusan Cyrillic and Latin layouts #70

Add Belarusan Cyrillic and Latin layouts #70

Belarusan commented Aug 13, 2024

Aga-C left a comment

Aga-C Aug 13, 2024

Belarusan Aug 14, 2024

Aga-C Aug 13, 2024

Belarusan commented Aug 14, 2024 •

edited

Loading

Aga-C commented Aug 14, 2024

Belarusan commented Aug 14, 2024

Aga-C commented Aug 14, 2024

Belarusan commented Aug 14, 2024

tenextractor commented Aug 16, 2024

Belarusan commented Aug 17, 2024

tenextractor commented Aug 17, 2024 •

edited

Loading

Belarusan commented Aug 17, 2024

naveensingh commented Oct 25, 2024

Belarusan commented Nov 4, 2024

	LANGUAGE_BELARUSIAN_CYRL -> R.xml.keys_belarusian_cyrl
	LANGUAGE_BELARUSIAN_CYRL -> R.xml.keys_letters_belarusian_cyrl

Add Belarusan Cyrillic and Latin layouts #70

Add Belarusan Cyrillic and Latin layouts #70

Conversation

Belarusan commented Aug 13, 2024

What is it?

Description of the changes in your PR

Fixes the following issue(s)

Acknowledgement

Aga-C left a comment

Choose a reason for hiding this comment

Aga-C Aug 13, 2024

Choose a reason for hiding this comment

Belarusan Aug 14, 2024

Choose a reason for hiding this comment

Aga-C Aug 13, 2024

Choose a reason for hiding this comment

Belarusan commented Aug 14, 2024 • edited Loading

Aga-C commented Aug 14, 2024

Belarusan commented Aug 14, 2024

Aga-C commented Aug 14, 2024

Belarusan commented Aug 14, 2024

tenextractor commented Aug 16, 2024

Belarusan commented Aug 17, 2024

tenextractor commented Aug 17, 2024 • edited Loading

Belarusan commented Aug 17, 2024

naveensingh commented Oct 25, 2024

Belarusan commented Nov 4, 2024

Belarusan commented Aug 14, 2024 •

edited

Loading

tenextractor commented Aug 17, 2024 •

edited

Loading