Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit all reply messages #178

Open
dongxinEric opened this issue Apr 24, 2019 · 1 comment
Open

Audit all reply messages #178

dongxinEric opened this issue Apr 24, 2019 · 1 comment
Assignees
@dongxinEric
Labels
cleanup Code or design cleanup
Milestone
2.0.0

Comments

@dongxinEric
Copy link
Contributor

We should audit all reply (ExtMsgReply) messages to make sure proper flags, fields and value types are set.
@dongxinEric dongxinEric added the cleanup Code or design cleanup label Apr 24, 2019
@dongxinEric dongxinEric added this to the 1.8.0 milestone Apr 24, 2019
@dongxinEric dongxinEric self-assigned this Apr 24, 2019
@dongxinEric
Copy link
Contributor Author

We need to make sure all reply messages comply to the OP_REPLY message format and the general header format

@apkar apkar modified the milestones: 1.8.0, 2.0.0 Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongxinEric dongxinEric

Labels
cleanup Code or design cleanup
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@dongxinEric @apkar