Wireshark: revise registering and unregistering taps #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor how taps are specified, to reduce copy-paste boilerplate. Check for success when registering each tap, log failures. (For an example of how this is helpful, this will show that the name of the TLS tap is no longer "tls" as of the upcoming Wireshark 4.4.) `init_globals()` gets called every time a file is loaded or a preference is changed, so add code to `cleanup_globals()` to unregister any taps registered in `init_globals()`. Avoids leaking unbounded tap registrations. Avoid registering taps entirely if the JA4 post-dissector has been disabled, to improve performance.
noeltimothy
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how taps are specified, to reduce copy-paste boilerplate.
Check for success when registering each tap, log failures. (For an example of how this is helpful, this will show that the name of the TLS tap is no longer "tls" as of the upcoming Wireshark 4.4.)
init_globals()gets called every time a file is loaded or a preference is changed, so add code tocleanup_globals()to unregister any taps registered ininit_globals(). Avoids leaking unbounded tap registrations.Avoid registering taps entirely if the JA4 post-dissector has been disabled, to improve performance.