Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_datascience directory created on build #913

Open
chrisequalsdev opened this issue Sep 14, 2023 · 2 comments
Open

_datascience directory created on build #913

chrisequalsdev opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
content repair Content is wrong and needs correction

Comments

@chrisequalsdev
Copy link
Contributor

After building, dir ./_site/_datascience is created which is a duplicate of ./_site/datascience. These are the only underscore dirs in the ./_site/ dir that are not asset related. This create some duplicate pages in the site.

For example:
normal page
underscore page

This creates two issues which may or may not really matter:

  1. Duplicate pages (search results might lead to the one that doesn't show a sidebar)
  2. Creates some issues for the broken link checking effort (although for automation purposes the ./_site/_datascience dir can be ignored with bundle exec htmlproofer ./_site --ignore-files "/\.\/_site\/_datascience\/.*/")

The broken links are because of the link to #main which exists in the base template and links to the top of the content on each page. This link doesn't work on underscore pages.

A normal example looks like this:
normal page
normal page main content

Underscore page example:
underscore page
underscore page main content

Basically I think the ./_site/_datascience needs to go. I'm not sure why that gets created.

Sidenote:
The same link issue also exists in three other pages too. I haven't looked into these yet.
https://sciwiki.fredhutch.org/archive/cluster_koshuBeta/index.html
https://sciwiki.fredhutch.org/archive/galaxy-on-prem/index.html
https://sciwiki.fredhutch.org/contributorTemplate/index.html

@chrisequalsdev chrisequalsdev added the content repair Content is wrong and needs correction label Sep 14, 2023
@vortexing
Copy link
Collaborator

This spot in the config might help us - perhaps we should explicitly EXCLUDE more folders?

include:

@laderast
Copy link
Collaborator

More research needed

@laderast laderast assigned laderast and dtenenba and unassigned laderast Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content repair Content is wrong and needs correction
Projects
None yet
Development

No branches or pull requests

4 participants