Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge properly for the LDC opcode #1271

Closed
xgreenx opened this issue Aug 2, 2023 · 1 comment
Closed

Charge properly for the LDC opcode #1271

xgreenx opened this issue Aug 2, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Aug 2, 2023

The LDC opcode benchmark is wrong because $rC represents only the length the users want to load. But if the contract itself is huge, the attacker can use zero $rC and execute very heavy operations for free.

Either the benchmark should work with the worst scenario(the size of the contract is always maximum like ConsensusParameters.contract_max_size) or we need to update the opcode itself and quired exact size of the contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants