Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos binary publishing #1489

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fix macos binary publishing #1489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b895ce
Fix macos binary publishing
xgreenx Nov 15, 2023
9f57be8
Fix macos binary publishing
xgreenx Nov 15, 2023
5e4e5ec
Fix macos binary publishing
xgreenx Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,13 +448,15 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Log in to the ghcr.io registry
if: matrix.job.os == 'buildjet-4vcpu-ubuntu-2204'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be added to the next login right? line 459-460

uses: docker/login-action@v1
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log in to the docker.io registry
if: matrix.job.os == 'buildjet-4vcpu-ubuntu-2204'
uses: docker/login-action@v2
with:
username: fuellabs
Expand Down
Loading