-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: update vm initialization benchmark #1505
dev: update vm initialization benchmark #1505
Conversation
benches/benches/vm_initialization.rs
Outdated
const N: usize = 16; | ||
for i in 0..N { | ||
let increment = 1024 / N; | ||
let script_size = 1024 * increment * i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const N: usize = 16; | |
for i in 0..N { | |
let increment = 1024 / N; | |
let script_size = 1024 * increment * i; | |
const N: usize = 20; | |
for i in 0..N { | |
let size = 1 << i; |
Somewhat surprisingly, based on local benchmarking, it seems that |
There's currently a problem with the way the TX is created for the benchmark: let size = 1 << i;
let script = vec![op::ret(1); size / Instruction::SIZE] When |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for help!
Updates #1502 to use dependent gas price for
vm_initialization
.This PR:
vm_initialization
gas cost to a dependent costfuel-vm
to the newly createdv0.42.2
This adds the following benchmarks to the suite:
Locally, this produces the following dependent cost for VM initialization: