Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last iteration in sequential opcode #2479

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Fix last iteration in sequential opcode #2479

merged 7 commits into from
Dec 13, 2024

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Dec 6, 2024 •
edited
Loading

Fixes #2022

Previously the read and write of the last key of the contract state was creating error because of multiple bad checks of limits. Also the key was increase in all case at the end of the loop causing the increase() to fail on overflow even if there is values to be inserted left.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT marked this pull request as ready for review December 6, 2024 17:16
@AurelienFT AurelienFT requested a review from a team December 6, 2024 17:16
xgreenx
xgreenx reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have contract_state_remove_range that has the same problem=)

crates/storage/src/vm_storage.rs Outdated Show resolved Hide resolved
tests/tests/vm_storage.rs Outdated Show resolved Hide resolved
@AurelienFT AurelienFT requested a review from a team December 6, 2024 20:50
xgreenx
xgreenx previously approved these changes Dec 7, 2024
View reviewed changes
@AurelienFT AurelienFT requested a review from a team December 10, 2024 09:48
@AurelienFT AurelienFT requested a review from xgreenx December 10, 2024 09:49
xgreenx
xgreenx previously approved these changes Dec 12, 2024
View reviewed changes
@AurelienFT AurelienFT requested a review from a team December 12, 2024 13:09
rymnc
rymnc reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! added some comments in line

crates/storage/src/vm_storage.rs Show resolved Hide resolved
crates/storage/src/vm_storage.rs Show resolved Hide resolved
crates/storage/src/vm_storage.rs Show resolved Hide resolved
@AurelienFT AurelienFT requested a review from rymnc December 13, 2024 11:07
@AurelienFT AurelienFT requested a review from xgreenx December 13, 2024 14:52
@AurelienFT AurelienFT enabled auto-merge (squash) December 13, 2024 20:26
@AurelienFT AurelienFT merged commit 825e18d into master Dec 13, 2024
29 checks passed
@AurelienFT AurelienFT deleted the fix_sequential_opcode_error_last_storage_key branch December 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@xgreenx xgreenx xgreenx approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequential opcodes return an error when touching the last storage key
3 participants
@AurelienFT @xgreenx @rymnc