-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rocksdb): remove getters for internal rocksdb handles, expose backup
instead
#2535
Open
rymnc
wants to merge
10
commits into
master
Choose a base branch
from
fix/db-backup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+533
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
rymnc
changed the title
chore(rocksdb): remove getters for internal rocksdb handles
chore(rocksdb): remove getters for internal rocksdb handles, expose Jan 7, 2025
backup
instead
6 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- crates/fuel-core/src/state/rocks_db.rs: Evaluated as low risk
- CHANGELOG.md: Evaluated as low risk
- crates/fuel-core/src/state/historical_rocksdb.rs: Evaluated as low risk
Comments suppressed due to low confidence (4)
crates/fuel-core/src/combined_database.rs:89
- The error message could be more descriptive. Consider including more context about the failure.
crate::database::Error::BackupError(anyhow::anyhow!("Failed to create temporary backup directory: {}", e))
crates/fuel-core/src/combined_database.rs:163
- The error message could be more descriptive. Consider including more context about the failure.
crate::database::Error::RestoreError(anyhow::anyhow!("Failed to create temporary restore directory: {}", e))
crates/fuel-core/src/combined_database.rs:133
- Ensure that temporary directories are properly removed in case of errors to avoid leaving residue.
std::fs::remove_dir_all(temp_backup_dir.path()).map_err(|e| {
crates/fuel-core/src/combined_database.rs:207
- Ensure that temporary directories are properly removed in case of errors to avoid leaving residue.
std::fs::remove_dir_all(temp_restore_dir.path()).map_err(|e| {
rymnc
changed the title
chore(rocksdb): remove getters for internal rocksdb handles, expose
feat(rocksdb): remove getters for internal rocksdb handles, expose Jan 7, 2025
backup
insteadbackup
instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
backup
and 2 functions,backup
andrestore
.CombinedDatabase
, similarly to theprune
api from rocksdb.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]