Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reader bin for interpretting data from fetcher #2537

Merged

Conversation

MitchTurner
Copy link
Member

@MitchTurner MitchTurner commented Jan 7, 2025

Linked Issues/PRs

Description

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

use std::collections::HashMap;

// const PATH: &str = "data/gas_costs_data.csv";
const PATH: &str = "/Users/jamesturner/fuel/fuel-core/crates/fuel-gas-price-algorithm/gas-price-data-fetcher/data/scrape_2.csv";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify this?

@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Jan 8, 2025
@rymnc rymnc marked this pull request as ready for review January 8, 2025 17:01
@MitchTurner MitchTurner merged commit aee73af into gas_price_simulation_data_retriever Jan 8, 2025
22 checks passed
@MitchTurner MitchTurner deleted the gas-price-data-reader branch January 8, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants