Fixing crash if json.loads returns a string (#248)

Future-House · Mar 8, 2024 · 8b46829 · 8b46829
1 parent 0d63f6f
commit 8b46829
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/paperqa/docs.py b/paperqa/docs.py
@@ -708,17 +708,15 @@ async def process(match):
                     except json.decoder.JSONDecodeError:
                         # fallback to string
                         success = False
+                    else:
+                        success = isinstance(result_data, dict)
                     if success:
                         try:
-                            context = result_data["summary"]
-                            score = result_data["relevance_score"]
-                            del result_data["summary"]
-                            del result_data["relevance_score"]
-                            if "question" in result_data:
-                                del result_data["question"]
+                            context = result_data.pop("summary")
+                            score = result_data.pop("relevance_score")
+                            result_data.pop("question", None)
                             extras = result_data
                         except KeyError:
-                            # fallback
                             success = False
                 # fallback to string (or json mode not enabled)
                 if not success or not self.prompts.summary_json: