override an arxiv with real doi if it has one

Future-House · Oct 23, 2024 · d88c838 · d88c838
1 parent d2282a8
commit d88c838
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/paperqa/clients/semantic_scholar.py b/paperqa/clients/semantic_scholar.py
@@ -156,10 +156,11 @@ async def parse_s2_to_doc_details(
     if "data" in paper_data:
         paper_data = paper_data["data"][0]
 
-    if "ArXiv" in paper_data["externalIds"]:
-        doi = "10.48550/arXiv." + paper_data["externalIds"]["ArXiv"]
-    elif "DOI" in paper_data["externalIds"]:
+    # DOI check goes 1st to override an ArXiV DOI
+    if "DOI" in paper_data["externalIds"]:
         doi = paper_data["externalIds"]["DOI"]
+    elif "ArXiv" in paper_data["externalIds"]:
+        doi = "10.48550/arXiv." + paper_data["externalIds"]["ArXiv"]
     else:
         raise DOINotFoundError(f"Could not find DOI for {paper_data}.")