Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed LangchainVectorStore, llms extra, and fixing up README #343

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Sep 9, 2024

  • LangchainVectorStore was basically dead code, and its test code was skipped
  • llms extra is a dead extra
  • README had many Python errors

This PR fixes all of these

@jamesbraza jamesbraza added the bug Something isn't working label Sep 9, 2024
@jamesbraza jamesbraza self-assigned this Sep 9, 2024
Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@jamesbraza jamesbraza merged commit 01bb765 into september-2024-release Sep 9, 2024
3 checks passed
@jamesbraza jamesbraza deleted the fixing-readme-no-lcvs branch September 9, 2024 23:43
@whitead whitead mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants