Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating test_tool_failure cassette #476

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jamesbraza
Copy link
Collaborator

Seen in this CI run:

    | vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('tests/cassettes/TestTaskDataset.test_tool_failure.yaml') in your current record mode ('none').

This PR regenerates the cassette so this test passes

@jamesbraza jamesbraza added the bug Something isn't working label Sep 24, 2024
@jamesbraza jamesbraza self-assigned this Sep 24, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@nadolskit
Copy link
Contributor

Would running these on new_episodes prevent these from breaking in the future?
https://vcrpy.readthedocs.io/en/latest/usage.html#new-episodes

@jamesbraza
Copy link
Collaborator Author

jamesbraza commented Sep 24, 2024

Would running these on new_episodes prevent these from breaking in the future? vcrpy.readthedocs.io/en/latest/usage.html#new-episodes

That would be fine, we'd just have to add a bot to commit the new cassettes. Otherwise we'd be regen'ing every time and not realize we have a stale cassette

Let's save this for a future PR

@jamesbraza jamesbraza merged commit 350edd4 into main Sep 24, 2024
5 checks passed
@jamesbraza jamesbraza deleted the updating-test-tool-failure-cassette branch September 24, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants